New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-duplicate ValueClassSupport
#913
De-duplicate ValueClassSupport
#913
Conversation
…pport into it (deleting the duplicated versions in Android and DSL modules)
@qoomon Can you take a look? What do you think? |
LGTM, waiting for a check by @qoomon as well. Thanks! |
Sorry for the late response, I'll do the review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however I think the wording platform is a little misleading.
Is there a reason why don't implement ValueClassSupport
within the common mockk module?
https://github.com/aSemy/mockk/tree/fix/de-duplicate-valueclasssupport/modules/mockk/src/commonMain/kotlin/io/mockk
Yeah I think the name could be better.
Because it can't be depended on by the other modules. If I were to refactor the project then I would have the root project be |
Thanks for the explanation. Regarding the module name I'd vote for mockk-core. |
+1 for mockk-core. |
2a26d49
to
1badf45
Compare
- remove InternalPlatformDsl.unboxClass util (it's the same as ValueClassSupport.boxedClass) - move InternalPlatformDsl.boxCast to ValueClassSupport
…pecifically for value classes, so it makes more sense to be in a general util class)
Okay, renamed! I changed the package too. I also removed |
LGTM @qoomon ? |
Love it 🙂 |
@aSemy thanks for your effort |
ValueClassSupport
into it (deleting the duplicated versions in Android and DSL modules)Fixes #857
Are there any other classes that can be de-duplicated?